| Conditions | 6 |
| Paths | 2 |
| Total Lines | 61 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | /* global API */ |
||
| 55 | function createFormIcon(el, form) { |
||
| 56 | var offset = el.offset(); |
||
| 57 | var width = el.width(); |
||
| 58 | var height = el.height(); |
||
| 59 | var margin = (el.css('margin')) ? parseInt(el.css('margin').replace('px', '')) : 0; |
||
| 60 | var padding = (el.css('padding')) ? parseInt(el.css('padding').replace('px', '')) : 0; |
||
| 61 | var paddingRight = parseInt(el.css('padding-right').replace('px', '')); |
||
| 62 | var fontSize = el.css('font-size'); |
||
| 63 | var borderh = (el.css('border-height')) ? el.css('border-height') : '2px'; |
||
| 64 | var borderw = (el.css('border-width')) ? el.css('border-width') : '2px'; |
||
| 65 | var borderColor = el.css('border-color'); |
||
| 66 | var borderHeight = parseInt(borderh.replace('px', '')); |
||
| 67 | var borderWidth = parseInt(borderw.replace('px', '')); |
||
| 68 | var iconWidth = width * 0.1; |
||
| 69 | var pickerButton = $j('<span class="passwordPickerIcon" style="display: inline-block"> </span>'); |
||
| 70 | $j('body').append(pickerButton); |
||
| 71 | if (el.find('.passwordPickerIcon').length > 0) { |
||
| 72 | pickerButton = el.find('.passwordPickerIcon')[0]; |
||
| 73 | } |
||
| 74 | |||
| 75 | |||
| 76 | //pickerButton.css('background-image', 'url("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAASCAYAAABSO15qAAAAAXNSR0IArs4c6QAAAPhJREFUOBHlU70KgzAQPlMhEvoQTg6OPoOjT+JWOnRqkUKHgqWP4OQbOPokTk6OTkVULNSLVc62oJmbIdzd95NcuGjX2/3YVI/Ts+t0WLE2ut5xsQ0O+90F6UxFjAI8qNcEGONia08e6MNONYwCS7EQAizLmtGUDEzTBNd1fxsYhjEBnHPQNG3KKTYV34F8ec/zwHEciOMYyrIE3/ehKAqIoggo9inGXKmFXwbyBkmSQJqmUNe15IRhCG3byphitm1/eUzDM4qR0TTNjEixGdAnSi3keS5vSk2UDKqqgizLqB4YzvassiKhGtZ/jDMtLOnHz7TE+yf8BaDZXA509yeBAAAAAElFTkSuQmCC")'); |
||
| 77 | pickerButton.css('background-image', 'url("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAEgAAABICAQAAAD/5HvMAAAAAmJLR0QA/4ePzL8AAAAJcEhZcwAACxMAAAsTAQCanBgAAAAHdElNRQfhAgcOLCT5d6srAAAAL3RFWHRDb21tZW50AEVkaXRlZCB3aXRoIGV6Z2lmLmNvbSBvbmxpbmUgR0lGIGVkaXRvctX/OoYAAAZUSURBVGjexZpfiBVVGMB/Z2buvfvn6urutq3rauqqqVEZmmBmiJVlT0EEEUGFFBEJQU9bD2IPgT6EEEUvUUhYPgoJYlJChrklIVTkn8BCTVt3dd3d+3fufD3cuXPP3Dv3/1yd4XLnzDlzzm++7zvfd/6MEm7roVCAoFAY7g/AQWEQJa5uM5AfDg9PXNhoSED5elt4XAryCwVIuf8h1BUGkNKuW6/NCBOnNHUHgFQdd24jkGrg7m0AUk3k1FGrhI7TkHmXdlBltAenbimJ66s9MKOie2+5sTqRHCytaAUJSQgN5UtG6pARmMWUEb6yfKWzdRSyUUWtGI3JR7XB2tzY30y3V+3pAEK2yGG0G6euJx2kUMhqI46FzTyi3EJUTixiTFWRkjsqstqEYzHA46xnA8NcJ8kR9euVPwZnVK6KHYmHVuts+OhlI+dJllSzd8eD6cqtmKIEoR04I7zOf4FVndr8WqqnQjtKjNpAhpgN4yzlPW5UrPLGht8T2yq2pqoDRaSzYZy5vMJE1bec2jKWXl9BRjWAog3jRNjkU1aCP/mG05z2VXzm+V25JRVkRJi2Awv4W6vgJk+zli76Wcgexsh5OZ8ce0LWBEspTJwI+3TVsMrnVJ7hKw3pLVku/cFARkg40M1hTTr3l+W/wE0v/wJLZbX0BbQsa0PCgTe0Kt6lJ6DEZ17+NNuJyMK879ElZHAmpJjVzWItdZ1bAd77EIXhSJyddKjLZeMlMXwCsRhsOoR28ZJ3Pc1kgKBzXKY4PhrARKlMaXj3JyPqasmdoJTyibJwz6QYp+b4hqXFeDWsSWQdGxFQTqkYteaUsJytOGToxCCBSSdJbLpwSBIjSgKHbjKk6cAigUEnabLEeJQlWl2PcIhkmS0M+VTU419p0OJ+3ikRYzvjpMjikCFNDps0WXKkSeOQIYWNTYoMDmlS5MiSIkOOJIKjOz8GKQ07aznrs+CPi/LXe1mxZy2q4fQbO39krg9nGaNatxeEL3W1lgC5bzATIpDwHes8Fa1iP9dK8g/4R2P5m4ZmpUJ3iOtjE1zAcHuVIstVBkpK9PmNRxW5vGHV/tCkM8v7jPia72BvSZmDpT1RkLzQ3BH2JAe5xoskSdGNwTQWcWaIshgTuEgXE8Ac0iTpIsI0JnESZIhjsEire4qj/OVrLc0oCzRfBRcDZl/K1aJEVQY4zDH2EfXJ0WYrnwPwG++QqejIV/IFg17qU8bKvJDDLz6gKV1l7qVZMKuYDKmLQJrLZQs23zNJL3CKf0hVmcp0aKkZMgFlvuUm89zrBMexsEvmphHDc/aXZH6FhuLEXRvLVTHiqxzxmbQR4KljJLyUyVQZjtJDg80N6SsZ38RQmMx11TQfiNFB8BKCX7bzffIqHEPc5V0fKNiY+Dqaf142K31qwr3expOswAHi7jMPcwATmGSMr8uiucFHbGeNm3rVtTt/+O3VLPDfvPp9Pd/0eXsvhOSrH63SqX+iP+D9+znulUizi9Ix+TLGvfwTLECVDaCjYpVr2hELiLKyir0Ma6LX7Wa3Z8pRnmIHHZ5Eooz4XuM6txApt1cneDrSi8GHVSR0nuFA0Bij2Fqpo2zgPgZ4jOd8s5FxFoH0Bs3MgltcLct4GcF2h+UF8kJjp0sCZ/HYwkltKC9c4xJjjPum1ZPci6r0rsGrsAYPnGBzP0sYwsYmjs0sUQymcYhxhLOFLlt2vMke100EHz/zLFeEqusggediGQYi3s6WQrl9stb0+gNSwbaAsBur+vS9WqaSZqP/2/yg2VLxPIlZa3mjVtjuaxJpEzuZJatVNcE57q692lJrJd9gjppqCmkuIzzEFnq5h7Nc4AjnqtpOI1sLTU+NFGASI4FgYYuqPQutc6+j9X0wkAh1rFrXuQorPS3jUA9O/cvCWZnXIk4btqea3qBt5LEG21Btxml4R1HajNPEFqe0+QWMdqqgGZMz2mekzfWA9m0CdxJjhpxHVuf3GC18alENSUzmYJN3hqL9nFqLmM0DKURVVpal7e/4tp/qkZCJItecylUwjgrYelL1tdDy1zEqFFNusZdVBrhzn+uo4k9CxGkwuBa3arV/ARwVEg4dVk0piAaivNPwNv/zA+FkSEQrLF/jyvteziisP3oouCAmFhYRLEwMHBQ2QpYs4yEgbfsflwyWnMm2PLkAAAAASUVORK5CYII=")'); |
||
| 78 | pickerButton.css('background-repeat', 'no-repeat'); |
||
| 79 | pickerButton.css('background-attachment', 'scroll'); |
||
| 80 | //pickerButton.css('background-size', '16px 18px'); |
||
| 81 | pickerButton.css('background-size', 'contain'); |
||
| 82 | pickerButton.css('background-position', '98% 50%'); |
||
| 83 | pickerButton.css('cursor', 'pointer'); |
||
| 84 | pickerButton.css('text-align', 'center'); |
||
| 85 | pickerButton.css('box-sizing', 'content-box'); |
||
| 86 | pickerButton.css('position', 'absolute'); |
||
| 87 | /* |
||
| 88 | pickerButton.css('background-color', 'rgb(234, 234, 234)'); |
||
| 89 | pickerButton.css('border-top-right-radius', el.css('border-top-right-radius')); |
||
| 90 | pickerButton.css('border-bottom-right-radius', el.css('border-bottom-right-radius')); |
||
| 91 | pickerButton.css('border-color', borderColor);*/ |
||
| 92 | |||
| 93 | pickerButton.css('z-index', '999'); |
||
| 94 | pickerButton.css('width', iconWidth); |
||
| 95 | |||
| 96 | |||
| 97 | pickerButton.css('padding', padding); |
||
| 98 | pickerButton.css('font-size', fontSize); |
||
| 99 | pickerButton.css('height', height); |
||
| 100 | pickerButton.css('margin', margin); |
||
| 101 | pickerButton.css('font-weight', el.css('font-weight')); |
||
| 102 | pickerButton.css('top', Math.round((offset.top + (height / 4) - margin / 2 - padding / 2 ) - (borderHeight / 2)) + 'px'); |
||
| 103 | pickerButton.css('left', Math.round((offset.left + width * 0.9) + paddingRight - padding + borderWidth) + 'px'); |
||
| 104 | |||
| 105 | |||
| 106 | var onClick = function () { |
||
| 107 | showPasswordPicker(form); |
||
| 108 | }; |
||
| 109 | |||
| 110 | //$j('body').append(pickerButton); |
||
| 111 | |||
| 112 | pickerButton.find('fa-key').click(onClick); |
||
| 113 | $j(pickerButton).click(onClick); |
||
| 114 | |||
| 115 | } |
||
| 116 | |||
| 336 | }); |